<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: notify the UI process when media controls are enabled/disabled"
href="https://bugs.webkit.org/show_bug.cgi?id=147802#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: notify the UI process when media controls are enabled/disabled"
href="https://bugs.webkit.org/show_bug.cgi?id=147802">bug 147802</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147802#c12">comment #12</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=258684&action=diff" name="attach_258684" title="Patch">attachment 258684</a> <a href="attachment.cgi?id=258684&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=258684&action=review">https://bugs.webkit.org/attachment.cgi?id=258684&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:74
> > - m_controls = adoptRef(*new MediaRemoteControls(context));
> > + m_controls = adoptRef(*new MediaRemoteControls(context, this));
>
> Why doesn't this use MediaRemoteControls::create() (which would need an
> extra parameter)?</span >
The bindings generator expects only one parameter (the ScriptExecutionContext) so I can't add another one. Since the only case where we need to store a backpointer to the media session is this one, I just create the object directly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>