[Webkit-unassigned] [Bug 147884] New: webkit-patch should not explode when $EDITOR is set incorrectly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 11 11:04:07 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=147884
Bug ID: 147884
Summary: webkit-patch should not explode when $EDITOR is set
incorrectly
Classification: Unclassified
Product: WebKit
Version: 528+ (Nightly build)
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
Assignee: webkit-unassigned at lists.webkit.org
Reporter: bburg at apple.com
STEPS TO REPRODUCE:
EDITOR=asdfjkl Tools/Scripts/webkit-patch upload -b <some-bug>
EXPECTED:
* Complains about not being able to edit changelogs, and gets on with life.
ACTUAL:
* A big, long, useless stack trace, and cannot continue uploading patch.
Traceback (most recent call last):
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module>
main()
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 79, in main
WebKitPatch(os.path.abspath(__file__)).main()
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
result = command.check_arguments_and_execute(options, args, self)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 54, in execute
self._sequence.run_and_handle_errors(tool, options, state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
self._run(tool, options, state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
step(tool, options).run(state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/editchangelog.py", line 35, in run
self._tool.user.edit_changelog(absolute_paths)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 148, in edit_changelog
self.edit(files)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 129, in edit
subprocess.call(args + files)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
return Popen(*popenargs, **kwargs).wait()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
raise child_exception
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/1360cbdf/attachment.html>
More information about the webkit-unassigned
mailing list