<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - webkit-patch should not explode when $EDITOR is set incorrectly"
href="https://bugs.webkit.org/show_bug.cgi?id=147884">147884</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>webkit-patch should not explode when $EDITOR is set incorrectly
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>bburg@apple.com
</td>
</tr></table>
<p>
<div>
<pre>STEPS TO REPRODUCE:
EDITOR=asdfjkl Tools/Scripts/webkit-patch upload -b <some-bug>
EXPECTED:
* Complains about not being able to edit changelogs, and gets on with life.
ACTUAL:
* A big, long, useless stack trace, and cannot continue uploading patch.
Traceback (most recent call last):
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module>
main()
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 79, in main
WebKitPatch(os.path.abspath(__file__)).main()
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
result = command.check_arguments_and_execute(options, args, self)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 54, in execute
self._sequence.run_and_handle_errors(tool, options, state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
self._run(tool, options, state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
step(tool, options).run(state)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/editchangelog.py", line 35, in run
self._tool.user.edit_changelog(absolute_paths)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 148, in edit_changelog
self.edit(files)
File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 129, in edit
subprocess.call(args + files)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
return Popen(*popenargs, **kwargs).wait()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
raise child_exception</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>