[Webkit-unassigned] [Bug 147802] Media Session: notify the UI process when media controls are enabled/disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147802

--- Comment #6 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #5)
> Comment on attachment 258643 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258643&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:50
> > +    if (m_session)
> > +        m_session->controlIsEnabledDidChange();
> 
> But maybe m_previousTrackEnabled didn't change?

This doesn't matter as all the media state will get sent over to the UI process anyway.

> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:5947
> > +    focusManager->playbackAttributeDidChange(this, sourceElementID, IsPlaying, state & MediaProducer::IsSourceElementPlaying);
> > +    focusManager->playbackAttributeDidChange(this, sourceElementID, IsPreviousTrackControlEnabled, state & MediaProducer::IsPreviousTrackControlEnabled);
> > +    focusManager->playbackAttributeDidChange(this, sourceElementID, IsNextTrackControlEnabled, state & MediaProducer::IsNextTrackControlEnabled);
> 
> Seems a bit weird to do it like this. Why not just pass  state and let
> focusManger figure things out?

Good idea. I'll send a revised patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/90b977a5/attachment.html>