<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: notify the UI process when media controls are enabled/disabled"
href="https://bugs.webkit.org/show_bug.cgi?id=147802#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: notify the UI process when media controls are enabled/disabled"
href="https://bugs.webkit.org/show_bug.cgi?id=147802">bug 147802</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147802#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=258643&action=diff" name="attach_258643" title="Patch">attachment 258643</a> <a href="attachment.cgi?id=258643&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=258643&action=review">https://bugs.webkit.org/attachment.cgi?id=258643&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:50
> > + if (m_session)
> > + m_session->controlIsEnabledDidChange();
>
> But maybe m_previousTrackEnabled didn't change?</span >
This doesn't matter as all the media state will get sent over to the UI process anyway.
<span class="quote">>
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:5947
> > + focusManager->playbackAttributeDidChange(this, sourceElementID, IsPlaying, state & MediaProducer::IsSourceElementPlaying);
> > + focusManager->playbackAttributeDidChange(this, sourceElementID, IsPreviousTrackControlEnabled, state & MediaProducer::IsPreviousTrackControlEnabled);
> > + focusManager->playbackAttributeDidChange(this, sourceElementID, IsNextTrackControlEnabled, state & MediaProducer::IsNextTrackControlEnabled);
>
> Seems a bit weird to do it like this. Why not just pass state and let
> focusManger figure things out?</span >
Good idea. I'll send a revised patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>