[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144956

--- Comment #115 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 258505
  --> https://bugs.webkit.org/attachment.cgi?id=258505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258505&action=review

>>>> Source/JavaScriptCore/bytecode/BytecodeUseDef.h:119
>>>> +    case op_new_arrow_func_exp:
>>> 
>>> This needs to also report the bound this operand as a use.
>> 
>> Do you mean that that op_new_arrow_func_exp should have name that report about bound |this|, for instance op_new_arrow_func_exp_with_bound_this? I'm not sure, because arrow function also has lexical |arguments| binding, and |super|, |new.target| as well, so after implementing some of this feature we need to change this name.
> 
> No, I mean that the op_new_arrowfunction has two bytecode operands it uses in this patch. 
> You need to report those as uses here. For example, you need to have it do:
>         functor(codeBlock, instruction, opcodeID, instruction[2].u.operand); // Scope
>         functor(codeBlock, instruction, opcodeID, instruction[4].u.operand); // Bound this.

Ohh, I got it. Please take a look if it ok now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150809/d9f1a7db/attachment.html>