<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956#c115">Comment # 115</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956">bug 144956</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=258505&action=diff" name="attach_258505" title="Patch">attachment 258505</a> <a href="attachment.cgi?id=258505&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258505&action=review">https://bugs.webkit.org/attachment.cgi?id=258505&action=review</a>
<span class="quote">>>>> Source/JavaScriptCore/bytecode/BytecodeUseDef.h:119
>>>> + case op_new_arrow_func_exp:
>>>
>>> This needs to also report the bound this operand as a use.
>>
>> Do you mean that that op_new_arrow_func_exp should have name that report about bound |this|, for instance op_new_arrow_func_exp_with_bound_this? I'm not sure, because arrow function also has lexical |arguments| binding, and |super|, |new.target| as well, so after implementing some of this feature we need to change this name.
>
> No, I mean that the op_new_arrowfunction has two bytecode operands it uses in this patch.
> You need to report those as uses here. For example, you need to have it do:
> functor(codeBlock, instruction, opcodeID, instruction[2].u.operand); // Scope
> functor(codeBlock, instruction, opcodeID, instruction[4].u.operand); // Bound this.</span >
Ohh, I got it. Please take a look if it ok now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>