[Webkit-unassigned] [Bug 147796] Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147796

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
(In reply to comment #2)
> [...]
> Dashboard.sortedRepositories.length], then I would write this as:
> 
> var sortedRepositories = Dashboard.sortedRepositories;
> var fragment = document.createDocumentFragment();
> fragment.appendChild(this._revisionContentWithPopoverForIteration(iteration,
> previousDisplayedIteration, sortedRepositories[0].name,
> sortedRepositories[0].trac));
> for (var i = 1; i < sortedRepositories.length; ++i) {
>     fragment.appendChild(document.createTextNode(" \uff0b "));
>     fragment.appendChild(this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, sortedRepositories[i].name, sortedRepositories[0].trac));

err, the for-loop body should read:

var content = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, sortedRepositories[i].name, sortedRepositories[0].trac);

if (!content)
    continue;

fragment.appendChild(document.createTextNode(" \uff0b ")); 
fragment.appendChild(content);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150807/8f8b9ab6/attachment.html>