<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal"."
href="https://bugs.webkit.org/show_bug.cgi?id=147796#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories other than "openSource" and "internal"."
href="https://bugs.webkit.org/show_bug.cgi?id=147796">bug 147796</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147796#c2">comment #2</a>)
<span class="quote">> [...]
> Dashboard.sortedRepositories.length], then I would write this as:
>
> var sortedRepositories = Dashboard.sortedRepositories;
> var fragment = document.createDocumentFragment();
> fragment.appendChild(this._revisionContentWithPopoverForIteration(iteration,
> previousDisplayedIteration, sortedRepositories[0].name,
> sortedRepositories[0].trac));
> for (var i = 1; i < sortedRepositories.length; ++i) {
> fragment.appendChild(document.createTextNode(" \uff0b "));
> fragment.appendChild(this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, sortedRepositories[i].name, sortedRepositories[0].trac));</span >
err, the for-loop body should read:
var content = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, sortedRepositories[i].name, sortedRepositories[0].trac);
if (!content)
continue;
fragment.appendChild(document.createTextNode(" \uff0b "));
fragment.appendChild(content);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>