[Webkit-unassigned] [Bug 147745] Media Session: notify focus manager clients when the playing state of the focused media element changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147745

--- Comment #3 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #2)
> Comment on attachment 258396 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258396&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:40
> > +typedef void (*WKMediaSessionFocusManagerDidChangePlayingState)(WKMediaSessionFocusManagerRef manager, bool isPaused, const void *clientInfo);
> 
> Will this ever have to handle more than play/pause state changes? If so, I
> recommend changing the names to PlaybackState instead of PlayingState and
> passing flags instead of a bool.

Good idea. In the future, we'll also need to notify clients whenever the previous/next track controls should be enabled/disabled. I'll generalize this code path so we can use it for said events.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150806/2656f87c/attachment.html>