[Webkit-unassigned] [Bug 147405] Checkboxes and radio buttons should scale when zooming or pinching to zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147405

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257964|review?                     |review+
              Flags|                            |

--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 257964
  --> https://bugs.webkit.org/attachment.cgi?id=257964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257964&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::paintToggleButton): Refactored to use drawCellOrFocusRingWithViewOntoContext.
> +        (WebCore::paintButton): Refactored to use drawCellOrFocusRingWithViewOntoContext.

Onto -> Into or With?

> Source/WebCore/platform/mac/ThemeMac.mm:681
> +        std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::createCompatibleBuffer(inflatedRect.size() + 2 * FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth), deviceScaleFactor, ColorSpaceDeviceRGB, context, false);
> +        {
> +            LocalCurrentGraphicsContext localContext(imageBuffer->context());
> +            if (drawButtonCell)
> +                [cell drawWithFrame:imageBufferDrawRect inView:view];
> +            
> +            if (drawFocusRing)
> +                needsRepaint = drawCellFocusRing(cell.get(), imageBufferDrawRect, view);
> +        }
> +        context->drawImageBuffer(imageBuffer.get(), ColorSpaceDeviceRGB, inflatedRect.location() - FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth));

We should ask Tim here, but I wonder if we want ColorSpaceSRGB.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150804/a58f46a0/attachment.html>