<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dino@apple.com" title="Dean Jackson <dino@apple.com>"> <span class="fn">Dean Jackson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Checkboxes and radio buttons should scale when zooming or pinching to zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=147405">bug 147405</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257964 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Checkboxes and radio buttons should scale when zooming or pinching to zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=147405#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Checkboxes and radio buttons should scale when zooming or pinching to zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=147405">bug 147405</a>
from <span class="vcard"><a class="email" href="mailto:dino@apple.com" title="Dean Jackson <dino@apple.com>"> <span class="fn">Dean Jackson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257964&action=diff" name="attach_257964" title="Patch">attachment 257964</a> <a href="attachment.cgi?id=257964&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257964&action=review">https://bugs.webkit.org/attachment.cgi?id=257964&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:15
> + (WebCore::paintToggleButton): Refactored to use drawCellOrFocusRingWithViewOntoContext.
> + (WebCore::paintButton): Refactored to use drawCellOrFocusRingWithViewOntoContext.</span >
Onto -> Into or With?
<span class="quote">> Source/WebCore/platform/mac/ThemeMac.mm:681
> + std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::createCompatibleBuffer(inflatedRect.size() + 2 * FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth), deviceScaleFactor, ColorSpaceDeviceRGB, context, false);
> + {
> + LocalCurrentGraphicsContext localContext(imageBuffer->context());
> + if (drawButtonCell)
> + [cell drawWithFrame:imageBufferDrawRect inView:view];
> +
> + if (drawFocusRing)
> + needsRepaint = drawCellFocusRing(cell.get(), imageBufferDrawRect, view);
> + }
> + context->drawImageBuffer(imageBuffer.get(), ColorSpaceDeviceRGB, inflatedRect.location() - FloatSize(buttonFocusRectOutlineWidth, buttonFocusRectOutlineWidth));</span >
We should ask Tim here, but I wonder if we want ColorSpaceSRGB.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>