[Webkit-unassigned] [Bug 147280] Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147280

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258106|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258106
  --> https://bugs.webkit.org/attachment.cgi?id=258106
Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.

View in context: https://bugs.webkit.org/attachment.cgi?id=258106&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:202
> +            if (repository === "openSource") {

We should use Dashboard.Repository.OpenSource.name instead of the string literal "openSource".

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:205
> +            } else if (repository === "internal") {

Similarly, we should use Dashboard.Repository.Internal.name instead of the string literal "internal".

> Tools/ChangeLog:11
> +        (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevent.

Nit: relevent => relevant

> Tools/ChangeLog:21
> +        Added "trac" parameter in order to specify the trac instance to use.

Nit: Please move this sentence such that it starts on line 20 (above) and break it across multiple lines if needed.

> Tools/ChangeLog:22
> +        Using "revision" property instead of "opensourceRevision" and "internalRevision".

Nit: Please move this sentence such that it starts on the same line as the last sentence (above) and break it across multiple lines if needed.

> Tools/ChangeLog:23
> +        (BuildbotQueueView.prototype.revisionContentForIteration): Passing the "repository" and trac

Nit: the "repository" => the repository name

> Tools/ChangeLog:24
> +        instance to _revisionContentWithPopoverForIteration

Nit: _revisionContentWithPopoverForIteration => _revisionContentWithPopoverForIteration().
(Notice the period at the end of suggested substitution).

> Tools/ChangeLog:25
> +        Using "revision" property instead of "opensourceRevision" and "internalRevision".

Nit: Please move this sentence such that it starts on line 24 (above) and break it across multiple lines if needed.

> Tools/ChangeLog:27
> +        constants for internal and opensource repositories

Nit: Missing a period at the end of this sentence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150804/b61e96dd/attachment-0001.html>