<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280">bug 147280</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258106 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions"
href="https://bugs.webkit.org/show_bug.cgi?id=147280">bug 147280</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258106&action=diff" name="attach_258106" title="Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.">attachment 258106</a> <a href="attachment.cgi?id=258106&action=edit" title="Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.">[details]</a></span>
Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258106&action=review">https://bugs.webkit.org/attachment.cgi?id=258106&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:202
> + if (repository === "openSource") {</span >
We should use Dashboard.Repository.OpenSource.name instead of the string literal "openSource".
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:205
> + } else if (repository === "internal") {</span >
Similarly, we should use Dashboard.Repository.Internal.name instead of the string literal "internal".
<span class="quote">> Tools/ChangeLog:11
> + (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevent.</span >
Nit: relevent => relevant
<span class="quote">> Tools/ChangeLog:21
> + Added "trac" parameter in order to specify the trac instance to use.</span >
Nit: Please move this sentence such that it starts on line 20 (above) and break it across multiple lines if needed.
<span class="quote">> Tools/ChangeLog:22
> + Using "revision" property instead of "opensourceRevision" and "internalRevision".</span >
Nit: Please move this sentence such that it starts on the same line as the last sentence (above) and break it across multiple lines if needed.
<span class="quote">> Tools/ChangeLog:23
> + (BuildbotQueueView.prototype.revisionContentForIteration): Passing the "repository" and trac</span >
Nit: the "repository" => the repository name
<span class="quote">> Tools/ChangeLog:24
> + instance to _revisionContentWithPopoverForIteration</span >
Nit: _revisionContentWithPopoverForIteration => _revisionContentWithPopoverForIteration().
(Notice the period at the end of suggested substitution).
<span class="quote">> Tools/ChangeLog:25
> + Using "revision" property instead of "opensourceRevision" and "internalRevision".</span >
Nit: Please move this sentence such that it starts on line 24 (above) and break it across multiple lines if needed.
<span class="quote">> Tools/ChangeLog:27
> + constants for internal and opensource repositories</span >
Nit: Missing a period at the end of this sentence.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>