[Webkit-unassigned] [Bug 147280] Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147280

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257853|review?                     |review+
              Flags|                            |

--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 257853
  --> https://bugs.webkit.org/attachment.cgi?id=257853
Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.

View in context: https://bugs.webkit.org/attachment.cgi?id=257853&action=review

Looks good. I noticed some very minor nits.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:207
> +    _revisionContentWithPopoverForIteration: function(iteration, previousIteration, repository, trac)

Would repositoryName be a better name for the argument repository?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:265
> +        var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, "openSource", webkitTrac);

We should pass Dashboard.Repository.OpenSource.name to _revisionContentWithPopoverForIteration() instead of hardcoding the value of Dashboard.Repository.OpenSource.name.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:270
> +        var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, "internal", internalTrac);

Similarly, we should pass Dashboard.Repository.Internal.name instead of hardcoding "internal" on this line.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:41
> +        OpenSource: { name: "openSource", sort: 0 },
> +        Internal: { name: "internal", sort: 1 },

I suggest that we rename the property "sort" to "order" to be consistent with the name of the property with the same purpose in the Dashboard.Platform dictionaries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150803/85676aed/attachment.html>