[Webkit-unassigned] [Bug 144487] Update speedometer patch to provide better UI and fix merge result bug.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144487

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 252132
  --> https://bugs.webkit.org/attachment.cgi?id=252132
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252132&action=review

> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:80
> ++            var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
> ++            var values = timeValues.map(function (time) { return 60 * 1000 * enabledSuites.length / time});

Alternatively, we can just use measuredValues.length.  That's probably better here.

> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:104
> ++            console.log(results);

Superflous logging.

> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:116
> -+ 
> ++

What's up with this change?

> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:120
> -+ 
> ++

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150501/3ad70940/attachment.html>