<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Update speedometer patch to provide better UI and fix merge result bug."
href="https://bugs.webkit.org/show_bug.cgi?id=144487#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Update speedometer patch to provide better UI and fix merge result bug."
href="https://bugs.webkit.org/show_bug.cgi?id=144487">bug 144487</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252132&action=diff" name="attach_252132" title="Patch">attachment 252132</a> <a href="attachment.cgi?id=252132&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252132&action=review">https://bugs.webkit.org/attachment.cgi?id=252132&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:80
> ++ var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
> ++ var values = timeValues.map(function (time) { return 60 * 1000 * enabledSuites.length / time});</span >
Alternatively, we can just use measuredValues.length. That's probably better here.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:104
> ++ console.log(results);</span >
Superflous logging.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:116
> -+
> ++</span >
What's up with this change?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch:120
> -+
> ++</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>