[Webkit-unassigned] [Bug 140261] Null ptr crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140261

--- Comment #24 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 247627
  --> https://bugs.webkit.org/attachment.cgi?id=247627
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247627&action=review

> Source/WebCore/ChangeLog:4
> +        WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock().

Unnecessary line break.

> Source/WebCore/ChangeLog:9
> +        We need to check its Containing Block that can be null.

How about below patch description ?

"We need to check whether RenderObject is valid in RenderView::fooSubtreeSelection functions because invalid object has caused a crash. This patch adds isValidObjectForNewSelection(), and use it."

> LayoutTests/ChangeLog:4
> +        WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock().

ditto.

> LayoutTests/editing/execCommand/crash-140261.html:13
> +if (window.testRunner)

Need to have an indentation (4 spaces).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150428/8ceef880/attachment.html>