<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Null ptr crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock"
href="https://bugs.webkit.org/show_bug.cgi?id=140261#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Null ptr crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock"
href="https://bugs.webkit.org/show_bug.cgi?id=140261">bug 140261</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=247627&action=diff" name="attach_247627" title="patch">attachment 247627</a> <a href="attachment.cgi?id=247627&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=247627&action=review">https://bugs.webkit.org/attachment.cgi?id=247627&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:4
> + WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock().</span >
Unnecessary line break.
<span class="quote">> Source/WebCore/ChangeLog:9
> + We need to check its Containing Block that can be null.</span >
How about below patch description ?
"We need to check whether RenderObject is valid in RenderView::fooSubtreeSelection functions because invalid object has caused a crash. This patch adds isValidObjectForNewSelection(), and use it."
<span class="quote">> LayoutTests/ChangeLog:4
> + WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock().</span >
ditto.
<span class="quote">> LayoutTests/editing/execCommand/crash-140261.html:13
> +if (window.testRunner)</span >
Need to have an indentation (4 spaces).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>