[Webkit-unassigned] [Bug 143872] [SOUP] Add initial implementation of NetworkProcess disk cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 26 23:01:37 PDT 2015


--- Comment #28 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #27)
> Comment on attachment 251679 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251679&action=review

Thanks for the review!

> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:119
> > +    userData = asyncData.release();
> You should be able to avoid this assignment by passing ayncData.release()
> directly.

Right, I moved it to make it explicit that using asyncData in the method call would end up in a crash, to avoid a future refactoring thinking, why are we using a variable for the buffer? I'll rather add a comment there, and move the release to the method call.

> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:192
> > +    userData = asyncData.release();
> Ditto.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150427/398d2941/attachment.html>

More information about the webkit-unassigned mailing list