<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872">bug 143872</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143872#c27">comment #27</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251679&action=diff" name="attach_251679" title="Patch">attachment 251679</a> <a href="attachment.cgi?id=251679&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251679&action=review">https://bugs.webkit.org/attachment.cgi?id=251679&action=review</a></span >
Thanks for the review!
<span class="quote">> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:119
> > + userData = asyncData.release();
>
> You should be able to avoid this assignment by passing ayncData.release()
> directly.</span >
Right, I moved it to make it explicit that using asyncData in the method call would end up in a crash, to avoid a future refactoring thinking, why are we using a variable for the buffer? I'll rather add a comment there, and move the release to the method call.
<span class="quote">> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:192
> > + userData = asyncData.release();
>
> Ditto.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>