[Webkit-unassigned] [Bug 144038] Add a script to run Speedometer and JetStream on a browser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 23:57:55 PDT 2015


--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 251614
  --> https://bugs.webkit.org/attachment.cgi?id=251614

View in context: https://bugs.webkit.org/attachment.cgi?id=251614&action=review

> Tools/ChangeLog:8
> +        Wrapper script to run benchmark

You need a period at the end of this sentence as well as a blank line afterwards.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:66
> +                    else:
> +                        _log.error('No result. Something went wrong. Will skip current benchmark.')
> +                        break
> +                    self.browserDriver.closeBrowsers()

Why don't we just do all of this inside except: instead?
It's probably okay to repeat self.browserDriver.closeBrowsers() twice
if that meant we can get rid of this ugly None-ness check.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150425/45bef77e/attachment.html>

More information about the webkit-unassigned mailing list