<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a script to run Speedometer and JetStream on a browser"
href="https://bugs.webkit.org/show_bug.cgi?id=144038#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a script to run Speedometer and JetStream on a browser"
href="https://bugs.webkit.org/show_bug.cgi?id=144038">bug 144038</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251614&action=diff" name="attach_251614" title="Patch">attachment 251614</a> <a href="attachment.cgi?id=251614&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251614&action=review">https://bugs.webkit.org/attachment.cgi?id=251614&action=review</a>
<span class="quote">> Tools/ChangeLog:8
> + Wrapper script to run benchmark</span >
You need a period at the end of this sentence as well as a blank line afterwards.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:66
> + else:
> + _log.error('No result. Something went wrong. Will skip current benchmark.')
> + break
> + self.browserDriver.closeBrowsers()</span >
Why don't we just do all of this inside except: instead?
It's probably okay to repeat self.browserDriver.closeBrowsers() twice
if that meant we can get rid of this ugly None-ness check.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>