[Webkit-unassigned] [Bug 144038] Add a script to automate browser based performance benchmarks (e.g. Speedometer and JetStream)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144038

--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 251599
  --> https://bugs.webkit.org/attachment.cgi?id=251599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251599&action=review

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:16
> +    if not builders:
> +        raise Exception("No driver in %s was found" % (builderFileName))

Ditto about "assert builders" to avoid duplicating the error message.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:40
> +        except:
> +            raise

Oh I guess I was wrong about this supressing the exception since it will pass on the original exception object
but it doesn't seem like we don't do it elsewhere in our codebase so it's probably a good idea.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:65
> +                        _log.error('No result. Something went wrong')

It seems like when we're encountered this error, we need to exit early instead of contiuning to execute.
Otherwise, we'll end up still reproducing results with a fewer number of samples which is undesirable.

> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:16
> +    if not drivers:
> +        raise Exception("No driver in %s was found" % (driverFileName))

Ditto about doing "assert drivers" to avoid duplicating the error message.

> Tools/Scripts/webkitpy/benchmark_runner/result_wrapper/result_wrapper_factory.py:17
> +    if not wrappers:
> +        raise Exception("No driver in %s was found" % (wrapperFileName))

Ditto about asserting to avoid code duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150425/7fe2afd6/attachment.html>