<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a script to automate browser based performance benchmarks (e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a script to automate browser based performance benchmarks (e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038">bug 144038</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251599&action=diff" name="attach_251599" title="Patch">attachment 251599</a> <a href="attachment.cgi?id=251599&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251599&action=review">https://bugs.webkit.org/attachment.cgi?id=251599&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:16
> + if not builders:
> + raise Exception("No driver in %s was found" % (builderFileName))</span >
Ditto about "assert builders" to avoid duplicating the error message.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:40
> + except:
> + raise</span >
Oh I guess I was wrong about this supressing the exception since it will pass on the original exception object
but it doesn't seem like we don't do it elsewhere in our codebase so it's probably a good idea.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:65
> + _log.error('No result. Something went wrong')</span >
It seems like when we're encountered this error, we need to exit early instead of contiuning to execute.
Otherwise, we'll end up still reproducing results with a fewer number of samples which is undesirable.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:16
> + if not drivers:
> + raise Exception("No driver in %s was found" % (driverFileName))</span >
Ditto about doing "assert drivers" to avoid duplicating the error message.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/result_wrapper/result_wrapper_factory.py:17
> + if not wrappers:
> + raise Exception("No driver in %s was found" % (wrapperFileName))</span >
Ditto about asserting to avoid code duplicate.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>