[Webkit-unassigned] [Bug 144046] [UNIX] Simplify the file descriptor handling in SharedMemory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 10:44:38 PDT 2015


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #251329|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 251329
  --> https://bugs.webkit.org/attachment.cgi?id=251329

View in context: https://bugs.webkit.org/attachment.cgi?id=251329&action=review

Looks OK.

> Source/WebKit2/Platform/IPC/Attachment.h:59
> +    Attachment(const Attachment&) = default;
> +    Attachment& operator=(Attachment&) = default;

I think you want = delete here, not = default. It doesn’t seem OK to just copy a file descriptor!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150422/17b89157/attachment.html>

More information about the webkit-unassigned mailing list