<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Simplify the file descriptor handling in SharedMemory"
href="https://bugs.webkit.org/show_bug.cgi?id=144046">bug 144046</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251329 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Simplify the file descriptor handling in SharedMemory"
href="https://bugs.webkit.org/show_bug.cgi?id=144046#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Simplify the file descriptor handling in SharedMemory"
href="https://bugs.webkit.org/show_bug.cgi?id=144046">bug 144046</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251329&action=diff" name="attach_251329" title="Patch">attachment 251329</a> <a href="attachment.cgi?id=251329&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251329&action=review">https://bugs.webkit.org/attachment.cgi?id=251329&action=review</a>
Looks OK.
<span class="quote">> Source/WebKit2/Platform/IPC/Attachment.h:59
> + Attachment(const Attachment&) = default;
> + Attachment& operator=(Attachment&) = default;</span >
I think you want = delete here, not = default. It doesn’t seem OK to just copy a file descriptor!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>