[Webkit-unassigned] [Bug 144000] Don't de-allocate FunctionRareData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 16:04:09 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144000

--- Comment #3 from Basile Clement <basile_clement at apple.com> ---
Comment on attachment 251263
  --> https://bugs.webkit.org/attachment.cgi?id=251263
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251263&action=review

>> Source/JavaScriptCore/runtime/FunctionRareData.cpp:-82
>> -    Base::finishCreation(vm);
> 
> Where do we call the super class finishCreation?

FunctionRareData no longer has a finishCreation member, so that is done by rareData->finishCreation(vm) in the FunctionRareData::create() call.
Is this bad style without the using Base::finishCreation; clause?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150421/2b6c4991/attachment.html>


More information about the webkit-unassigned mailing list