<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Don't de-allocate FunctionRareData"
href="https://bugs.webkit.org/show_bug.cgi?id=144000#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Don't de-allocate FunctionRareData"
href="https://bugs.webkit.org/show_bug.cgi?id=144000">bug 144000</a>
from <span class="vcard"><a class="email" href="mailto:basile_clement@apple.com" title="Basile Clement <basile_clement@apple.com>"> <span class="fn">Basile Clement</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251263&action=diff" name="attach_251263" title="The patch">attachment 251263</a> <a href="attachment.cgi?id=251263&action=edit" title="The patch">[details]</a></span>
The patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251263&action=review">https://bugs.webkit.org/attachment.cgi?id=251263&action=review</a>
<span class="quote">>> Source/JavaScriptCore/runtime/FunctionRareData.cpp:-82
>> - Base::finishCreation(vm);
>
> Where do we call the super class finishCreation?</span >
FunctionRareData no longer has a finishCreation member, so that is done by rareData->finishCreation(vm) in the FunctionRareData::create() call.
Is this bad style without the using Base::finishCreation; clause?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>