[Webkit-unassigned] [Bug 143997] New: Autogenerate cmakeconfig.h.cmake

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 09:52:42 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143997

            Bug ID: 143997
           Summary: Autogenerate cmakeconfig.h.cmake
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

There are too many features missing from cmakeconfig.h.cmake:

ENABLE_ACCESSIBILITY
ENABLE_LETTERPRESS
ENABLE_MAC_LONG_PRESS
ENABLE_PLUGIN_PROCESS_GTK2
ENABLE_SPEECH_SYNTHESIS
ENABLE_THREADED_COMPOSITOR
USE_REDIRECTED_XCOMPOSITE_WINDOW

We should autogenerate this file so that we don't have to add new options in multiple places. It's too easy to forget.

There are also a few things listed in that file that are not proper WebKit features (but which probably should be), which will be lost if we autogenerate this file:

ENABLE_CREDENTIAL_STORAGE
ENABLE_EVENT_MODE_METATAGS
ENABLE_FIXED_REPORTED_SIZE
ENABLE_FTL_NATIVE_CALL_INLINING
ENABLE_INDEXED_DATABASE_IN_WORKERS
ENABLE_SMOOTH_SCROLLING
ENABLE_VIEWPORT_REFLOW
WTF_USE_GEOCLUE2
HAVE_LLVM
HAVE_GTK_UNIX_PRINTING
WTF_CPU_ARM64_CORTEXA53

We'll need to define those with WEBKIT_OPTION_DEFINE to keep them. But we should do that regardless, as otherwise they're not presented as options to the user in the list of features that prints after running cmake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150421/6a20fe2a/attachment-0001.html>


More information about the webkit-unassigned mailing list