<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Autogenerate cmakeconfig.h.cmake"
href="https://bugs.webkit.org/show_bug.cgi?id=143997">143997</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Autogenerate cmakeconfig.h.cmake
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<pre>There are too many features missing from cmakeconfig.h.cmake:
ENABLE_ACCESSIBILITY
ENABLE_LETTERPRESS
ENABLE_MAC_LONG_PRESS
ENABLE_PLUGIN_PROCESS_GTK2
ENABLE_SPEECH_SYNTHESIS
ENABLE_THREADED_COMPOSITOR
USE_REDIRECTED_XCOMPOSITE_WINDOW
We should autogenerate this file so that we don't have to add new options in multiple places. It's too easy to forget.
There are also a few things listed in that file that are not proper WebKit features (but which probably should be), which will be lost if we autogenerate this file:
ENABLE_CREDENTIAL_STORAGE
ENABLE_EVENT_MODE_METATAGS
ENABLE_FIXED_REPORTED_SIZE
ENABLE_FTL_NATIVE_CALL_INLINING
ENABLE_INDEXED_DATABASE_IN_WORKERS
ENABLE_SMOOTH_SCROLLING
ENABLE_VIEWPORT_REFLOW
WTF_USE_GEOCLUE2
HAVE_LLVM
HAVE_GTK_UNIX_PRINTING
WTF_CPU_ARM64_CORTEXA53
We'll need to define those with WEBKIT_OPTION_DEFINE to keep them. But we should do that regardless, as otherwise they're not presented as options to the user in the list of features that prints after running cmake.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>