[Webkit-unassigned] [Bug 143880] Favicons are not always loaded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143880

--- Comment #9 from peavo at outlook.com ---
(In reply to comment #7)
> Comment on attachment 251020 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251020&action=review
> 

Thanks for the review :)

> Seems like a good change.
> 
> I believe this patch changes behavior in two ways:
> 
> - It ignores MIME types entirely.
> - It chooses the last icon seen rather than the first one with the
> appropriate MIME type.
> 
> We have to be sure that both of those changes are desired.
> 

The latest patch is consistent with previous behavior. If you think we should go on and ignore MIME types entirely and always pick the last icon, this is just a minor modification of the current patch.

> I have a few thoughts:
> 
> 1) First, a question: Is this fixing a regression from the recent changes,
> or has it behaved this way for a long time and we just noticed that it’s not
> good?

I believe this is a recent regression, where favicons without mime type are not loaded (unless there is a favicon at the default location).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/41db842a/attachment.html>