<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Favicons are not always loaded."
href="https://bugs.webkit.org/show_bug.cgi?id=143880#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Favicons are not always loaded."
href="https://bugs.webkit.org/show_bug.cgi?id=143880">bug 143880</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143880#c7">comment #7</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=251020&action=diff" name="attach_251020" title="Patch">attachment 251020</a> <a href="attachment.cgi?id=251020&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251020&action=review">https://bugs.webkit.org/attachment.cgi?id=251020&action=review</a>
> </span >
Thanks for the review :)
<span class="quote">> Seems like a good change.
>
> I believe this patch changes behavior in two ways:
>
> - It ignores MIME types entirely.
> - It chooses the last icon seen rather than the first one with the
> appropriate MIME type.
>
> We have to be sure that both of those changes are desired.
> </span >
The latest patch is consistent with previous behavior. If you think we should go on and ignore MIME types entirely and always pick the last icon, this is just a minor modification of the current patch.
<span class="quote">> I have a few thoughts:
>
> 1) First, a question: Is this fixing a regression from the recent changes,
> or has it behaved this way for a long time and we just noticed that it’s not
> good?</span >
I believe this is a recent regression, where favicons without mime type are not loaded (unless there is a favicon at the default location).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>