[Webkit-unassigned] [Bug 143763] [W32] Wrong configure tests for OpenGL on Windows, wrong ifdefs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143763

--- Comment #3 from LRN <lrn1986 at gmail.com> ---
(In reply to comment #2)
> Created attachment 251067 [details]
> wk patch
> 
> Just in case, this is the only change I use with webkit-2.4 branch at
> revision 182543, even I configure with:
> 
> --enable-win32-target --enable-spellcheck --enable-jit --disable-geolocation
> --disable-video --disable-web-audio --disable-webgl
> --disable-accelerated-compositing --disable-glx --disable-egl
> --disable-gles2 --disable-webkit2 --disable-gtk-doc --disable-gtk-doc-html
> --disable-gtk-doc-pdf
> 
> thus maybe the LRN changes are skipped completely for me.

These are practically equivalent.

This:

+    elif test "$os_win32" = "yes"; then
+        acceleration_description="$acceleration_description (gl"
+        OPENGL_LIBS="-lopengl32"
     else
         acceleration_description="$acceleration_description (gl"
         OPENGL_LIBS="-lGL"

comes just a few lines above this:

     else
         acceleration_description="$acceleration_description (gl"
-        OPENGL_LIBS="-lGL"
+        case "$host" in
+            *-*-mingw*)
+                OPENGL_LIBS="-lopengl32"
+                ;;
+            *)
+                OPENGL_LIBS="-lGL"
+                ;;
+        esac

and does the same thing in a slightly diffrent way (checks for os_win32, not host).

Also, AFAIU, some webgl code is still compiled even with --disable-webgl. I didn't dig any further though. My configure arguments are:
    --disable-x11-target \
    --enable-win32-target \
    --enable-jit \
    --with-gtk=3.0 \
    --enable-webgl \
    --disable-webkit2 \
    --enable-spellcheck \
    --disable-geolocation \
    --disable-accelerated-compositing \
    --enable-debug-symbols=min \
    --enable-optimizations \
    --enable-introspection \
    --enable-gtk-doc \
    --enable-silent-rules \

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150418/c0aec808/attachment.html>