<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [W32] Wrong configure tests for OpenGL on Windows, wrong ifdefs"
href="https://bugs.webkit.org/show_bug.cgi?id=143763#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [W32] Wrong configure tests for OpenGL on Windows, wrong ifdefs"
href="https://bugs.webkit.org/show_bug.cgi?id=143763">bug 143763</a>
from <span class="vcard"><a class="email" href="mailto:lrn1986@gmail.com" title="LRN <lrn1986@gmail.com>"> <span class="fn">LRN</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143763#c2">comment #2</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=251067" name="attach_251067" title="wk patch">attachment 251067</a> <a href="attachment.cgi?id=251067&action=edit" title="wk patch">[details]</a></span>
> wk patch
>
> Just in case, this is the only change I use with webkit-2.4 branch at
> revision 182543, even I configure with:
>
> --enable-win32-target --enable-spellcheck --enable-jit --disable-geolocation
> --disable-video --disable-web-audio --disable-webgl
> --disable-accelerated-compositing --disable-glx --disable-egl
> --disable-gles2 --disable-webkit2 --disable-gtk-doc --disable-gtk-doc-html
> --disable-gtk-doc-pdf
>
> thus maybe the LRN changes are skipped completely for me.</span >
These are practically equivalent.
This:
+ elif test "$os_win32" = "yes"; then
+ acceleration_description="$acceleration_description (gl"
+ OPENGL_LIBS="-lopengl32"
else
acceleration_description="$acceleration_description (gl"
OPENGL_LIBS="-lGL"
comes just a few lines above this:
else
acceleration_description="$acceleration_description (gl"
- OPENGL_LIBS="-lGL"
+ case "$host" in
+ *-*-mingw*)
+ OPENGL_LIBS="-lopengl32"
+ ;;
+ *)
+ OPENGL_LIBS="-lGL"
+ ;;
+ esac
and does the same thing in a slightly diffrent way (checks for os_win32, not host).
Also, AFAIU, some webgl code is still compiled even with --disable-webgl. I didn't dig any further though. My configure arguments are:
--disable-x11-target \
--enable-win32-target \
--enable-jit \
--with-gtk=3.0 \
--enable-webgl \
--disable-webkit2 \
--enable-spellcheck \
--disable-geolocation \
--disable-accelerated-compositing \
--enable-debug-symbols=min \
--enable-optimizations \
--enable-introspection \
--enable-gtk-doc \
--enable-silent-rules \</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>