[Webkit-unassigned] [Bug 143897] prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143897

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251045|review?                     |review-
              Flags|                            |

--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 251045
  --> https://bugs.webkit.org/attachment.cgi?id=251045
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

View in context: https://bugs.webkit.org/attachment.cgi?id=251045&action=review

r- for commented out code.

> Tools/Scripts/prepare-ChangeLog:291
> +                # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) {

This shouldn't be commented out.  We don't check in commented out code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150417/922dbb58/attachment.html>