<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks"
href="https://bugs.webkit.org/show_bug.cgi?id=143897">bug 143897</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251045 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks"
href="https://bugs.webkit.org/show_bug.cgi?id=143897#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks"
href="https://bugs.webkit.org/show_bug.cgi?id=143897">bug 143897</a>
from <span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251045&action=diff" name="attach_251045" title="prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.">attachment 251045</a> <a href="attachment.cgi?id=251045&action=edit" title="prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.">[details]</a></span>
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251045&action=review">https://bugs.webkit.org/attachment.cgi?id=251045&action=review</a>
r- for commented out code.
<span class="quote">> Tools/Scripts/prepare-ChangeLog:291
> + # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) {</span >
This shouldn't be commented out. We don't check in commented out code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>