[Webkit-unassigned] [Bug 143851] Inline JSFunction allocation in FTL
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 16 16:01:31 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=143851
--- Comment #3 from Basile Clement <basile_clement at apple.com> ---
(In reply to comment #2)
> Comment on attachment 250959 [details]
> Tentative patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250959&action=review
>
> Looks good!
>
> > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2943
> > + // We don't need memory barriers since we just fast-created the activation, so the
> > + // activation must be young.
>
> probably don't need this comment, or you can replace "activation" with
> "function"
It was there in the createCompileActivation() inlining, so I supposed it would make sense to have here as well. Good catch on "activation"/"function", fixing that.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/3a6e6ad0/attachment.html>
More information about the webkit-unassigned
mailing list