<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Inline JSFunction allocation in FTL"
href="https://bugs.webkit.org/show_bug.cgi?id=143851#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Inline JSFunction allocation in FTL"
href="https://bugs.webkit.org/show_bug.cgi?id=143851">bug 143851</a>
from <span class="vcard"><a class="email" href="mailto:basile_clement@apple.com" title="Basile Clement <basile_clement@apple.com>"> <span class="fn">Basile Clement</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143851#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=250959&action=diff" name="attach_250959" title="Tentative patch">attachment 250959</a> <a href="attachment.cgi?id=250959&action=edit" title="Tentative patch">[details]</a></span>
> Tentative patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=250959&action=review">https://bugs.webkit.org/attachment.cgi?id=250959&action=review</a>
>
> Looks good!
>
> > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2943
> > + // We don't need memory barriers since we just fast-created the activation, so the
> > + // activation must be young.
>
> probably don't need this comment, or you can replace "activation" with
> "function"</span >
It was there in the createCompileActivation() inlining, so I supposed it would make sense to have here as well. Good catch on "activation"/"function", fixing that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>