[Webkit-unassigned] [Bug 143334] Remove unnecessary ASSERT from XMLDocumentParser::notifyFinished()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 16 14:53:27 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143334

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 249976
  --> https://bugs.webkit.org/attachment.cgi?id=249976
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249976&action=review

Couldn't we have a layout test for this by exposing MemoryCache::setDisabled() via Internals?

> Source/WebCore/xml/parser/XMLDocumentParser.cpp:-226
> -    ASSERT(m_pendingScript->accessCount() > 0);

Maybe ASSERT(m_pendingScript->accessCount() > 0 || MemoryCache::singleton().disabled()); then?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/40fbae90/attachment.html>


More information about the webkit-unassigned mailing list