<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove unnecessary ASSERT from XMLDocumentParser::notifyFinished()"
href="https://bugs.webkit.org/show_bug.cgi?id=143334#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove unnecessary ASSERT from XMLDocumentParser::notifyFinished()"
href="https://bugs.webkit.org/show_bug.cgi?id=143334">bug 143334</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=249976&action=diff" name="attach_249976" title="proposed patch">attachment 249976</a> <a href="attachment.cgi?id=249976&action=edit" title="proposed patch">[details]</a></span>
proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249976&action=review">https://bugs.webkit.org/attachment.cgi?id=249976&action=review</a>
Couldn't we have a layout test for this by exposing MemoryCache::setDisabled() via Internals?
<span class="quote">> Source/WebCore/xml/parser/XMLDocumentParser.cpp:-226
> - ASSERT(m_pendingScript->accessCount() > 0);</span >
Maybe ASSERT(m_pendingScript->accessCount() > 0 || MemoryCache::singleton().disabled()); then?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>