[Webkit-unassigned] [Bug 142958] unsafety GenericEventQueue operation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142958

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249222|review?                     |review-
              Flags|                            |

--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 249222
  --> https://bugs.webkit.org/attachment.cgi?id=249222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249222&action=review

> Source/WebCore/ChangeLog:8
> +

This changelog does not explain what you are trying to fix. Also you have no layout test to confirm you are fixing something.

(I also read the comment on the bug but it is not clear at all)

>> Source/WebCore/dom/GenericEventQueue.cpp:47
>> +        close();
> 
> What bug does this fix?
> 
> As far as I can tell, close() doesn't have any effects that would be observable after object destruction, so this proposed change doesn't fix anything.

I agree with ap here, calling close() in the destructor is not helpful. All it does is:
m_weakPtrFactory.revokeAll();
m_pendingEvents.clear();

Both are already happening during the regular destruction process when those 2 data members are destroyed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/5f45e6fc/attachment.html>