<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - unsafety GenericEventQueue operation"
href="https://bugs.webkit.org/show_bug.cgi?id=142958">bug 142958</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #249222 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - unsafety GenericEventQueue operation"
href="https://bugs.webkit.org/show_bug.cgi?id=142958#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - unsafety GenericEventQueue operation"
href="https://bugs.webkit.org/show_bug.cgi?id=142958">bug 142958</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=249222&action=diff" name="attach_249222" title="Patch">attachment 249222</a> <a href="attachment.cgi?id=249222&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249222&action=review">https://bugs.webkit.org/attachment.cgi?id=249222&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> +</span >
This changelog does not explain what you are trying to fix. Also you have no layout test to confirm you are fixing something.
(I also read the comment on the bug but it is not clear at all)
<span class="quote">>> Source/WebCore/dom/GenericEventQueue.cpp:47
>> + close();
>
> What bug does this fix?
>
> As far as I can tell, close() doesn't have any effects that would be observable after object destruction, so this proposed change doesn't fix anything.</span >
I agree with ap here, calling close() in the destructor is not helpful. All it does is:
m_weakPtrFactory.revokeAll();
m_pendingEvents.clear();
Both are already happening during the regular destruction process when those 2 data members are destroyed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>