[Webkit-unassigned] [Bug 143783] Network Cache: Inline small body data to record file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143783

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250824|review?                     |review+
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 250824
  --> https://bugs.webkit.org/attachment.cgi?id=250824
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250824&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:349
> +        return { };

Slight preference for "return Nullopt;"

>> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:497
>> +    const size_t maximumInlineBodySize = 16 << 10;
> 
> Not sure what the preferred style is but writing this as 16 * 1024 would be clearer to me than the bitshift.

I agree with Pratik here.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:516
> +        bool storeAsBlob = shouldStoreBodyAsBlob(write.record.body);

shouldStoreAsBlob as per our boolean variable naming coding style?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/8a63a79b/attachment.html>