<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Inline small body data to record file"
href="https://bugs.webkit.org/show_bug.cgi?id=143783">bug 143783</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250824 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Inline small body data to record file"
href="https://bugs.webkit.org/show_bug.cgi?id=143783#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Inline small body data to record file"
href="https://bugs.webkit.org/show_bug.cgi?id=143783">bug 143783</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250824&action=diff" name="attach_250824" title="patch">attachment 250824</a> <a href="attachment.cgi?id=250824&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250824&action=review">https://bugs.webkit.org/attachment.cgi?id=250824&action=review</a>
r=me
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:349
> + return { };</span >
Slight preference for "return Nullopt;"
<span class="quote">>> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:497
>> + const size_t maximumInlineBodySize = 16 << 10;
>
> Not sure what the preferred style is but writing this as 16 * 1024 would be clearer to me than the bitshift.</span >
I agree with Pratik here.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:516
> + bool storeAsBlob = shouldStoreBodyAsBlob(write.record.body);</span >
shouldStoreAsBlob as per our boolean variable naming coding style?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>