[Webkit-unassigned] [Bug 143750] Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 09:22:57 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143750

--- Comment #10 from Sungmann Cho <sungmann.cho at navercorp.com> ---
(In reply to comment #7)
> Comment on attachment 250791 [details]
> Patch
> 
> Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
> place as init list.
> 
> I think this one would be the least ugly solution
> 
> NotificationPermissionRequestManager::
> NotificationPermissionRequestManager(WebPage* page)
> {
> #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
>     m_page = page
> #else
>     UNUSED_PARAM(page);
> #endif
> }

Agreed. But the member initialization is slightly different from the assignment.
Any thoughts on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/657f93bb/attachment.html>


More information about the webkit-unassigned mailing list