[Webkit-unassigned] [Bug 143750] Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143750

Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at webkit.org

--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
(In reply to comment #8)
> (In reply to comment #6)
> > Comment on attachment 250791 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=250791&action=review
> > 
> > > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65
> > > +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS)
> > 
> > I don't like to use unnecessary macro. Probably it looks Ossy wants to use a
> > thing similar to below style. 
> > 
> > NotificationPermissionRequestManager::
> > NotificationPermissionRequestManager(WebPage* page)
> > {
> > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> >     m_page = page;
> > #else
> >     UNUSED_PARAM(page);
> > #endif
> > }
> 
> haha, you must be a thought-reader :)

Because you and I have dealt with similar issues many times. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/76b32f66/attachment-0001.html>