[Webkit-unassigned] [Bug 143753] [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143753

Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250788|review?                     |review-
              Flags|                            |

--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 250788
  --> https://bugs.webkit.org/attachment.cgi?id=250788
[GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x

View in context: https://bugs.webkit.org/attachment.cgi?id=250788&action=review

> Source/WTF/ChangeLog:15
> +        [W32] Change printf format attribute to gnu_printf, MinGW compatibility
> +
> +        "printf" means "gnu_printf" when compiling for non-Windows and means
> +        "ms_printf" when compiling for Windows. The code, however, does seems to be
> +        assuming gnu_printf (judging by the use of %z and %l).
> +
> +        Fix this by explicitly specifying gnu_printf format style.
> +        To ensure that gnu-compatible printf implementation is used, compile
> +        with -D__USE_MINGW_ANSI_STDIO=1, it will automagically turn all *printf()
> +        invocations into __mingw_*printf(), which are gnu-compatible.
> +
> +        Only one function that won't be turned is _vsnprintf(). Ifdef its use and
> +        call vsnprintf() instead when __USE_MINGW_ANSI_STDIO != 0.

It seems it is unrelated to this change.

> Source/WTF/ChangeLog:23
> +        * wtf/Assertions.cpp:
> +        * wtf/Assertions.h:

ditto

> Source/WTF/wtf/Platform.h:616
> +#ifdef _MSC_VER
>  #include <WTF/WTFHeaderDetection.h>
> +#endif

It is a generated header (see WTFGenerated.make) which is used by Apple Windows port.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/276cfb8d/attachment-0001.html>