<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753">bug 143753</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250788 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753">bug 143753</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250788&action=diff" name="attach_250788" title="[GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x">attachment 250788</a> <a href="attachment.cgi?id=250788&action=edit" title="[GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x">[details]</a></span>
[GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250788&action=review">https://bugs.webkit.org/attachment.cgi?id=250788&action=review</a>
<span class="quote">> Source/WTF/ChangeLog:15
> + [W32] Change printf format attribute to gnu_printf, MinGW compatibility
> +
> + "printf" means "gnu_printf" when compiling for non-Windows and means
> + "ms_printf" when compiling for Windows. The code, however, does seems to be
> + assuming gnu_printf (judging by the use of %z and %l).
> +
> + Fix this by explicitly specifying gnu_printf format style.
> + To ensure that gnu-compatible printf implementation is used, compile
> + with -D__USE_MINGW_ANSI_STDIO=1, it will automagically turn all *printf()
> + invocations into __mingw_*printf(), which are gnu-compatible.
> +
> + Only one function that won't be turned is _vsnprintf(). Ifdef its use and
> + call vsnprintf() instead when __USE_MINGW_ANSI_STDIO != 0.</span >
It seems it is unrelated to this change.
<span class="quote">> Source/WTF/ChangeLog:23
> + * wtf/Assertions.cpp:
> + * wtf/Assertions.h:</span >
ditto
<span class="quote">> Source/WTF/wtf/Platform.h:616
> +#ifdef _MSC_VER
> #include <WTF/WTFHeaderDetection.h>
> +#endif</span >
It is a generated header (see WTFGenerated.make) which is used by Apple Windows port.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>