[Webkit-unassigned] [Bug 143652] Network Cache: Deduplicate body data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143652

--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:60
> > +            unlink(filePath.data());
> 
> Why aren't we using WebCore::deleteFile()?

I don't use the abstractions in this file because

- Existing abstractions don't cover everything needed and I don't want to expand them for no practical benefit. For consistency I use system calls everywhere.
- No one seems to be interested in making non-Posix port.
- Here specifically I want to to unlink, not delete anything. deleteFile might do wrong thing on non-Posix platform.

> Why are we copying the Digest? (it is an std::array<uint8_t, 20>).

It is still cheap and it reads better. Compiler may optimize moves.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150414/8774126a/attachment.html>